Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Click on datapoint to view proofs and navigate to autosynced proofs #423

Merged
merged 3 commits into from
Mar 17, 2025

Conversation

fabianferno
Copy link
Member

@fabianferno fabianferno commented Mar 12, 2025

  1. Click on datapoint on a project's impact charts: https://gap-app-v2-git-feat-show-proof-on-charts-karma-devs.vercel.app/project/karma-gap/impact
    image

  2. Modal opens with View proof button
    image

  3. Clicking on View Proof takes you to the proof page
    image

- Enhance prepareChartData function to include proof information
- Implement interactive chart point selection with modal for detailed view
- Add ability to view proof link for specific data points in OutputsAndOutcomes component
- Add parseProofUrls helper function to handle comma-separated URLs
- Update proof display to support multiple URLs in both table and modal views
- Improve URL validation and display with truncation and multiple link rendering
@fabianferno fabianferno added the enhancement New feature or request label Mar 12, 2025
@fabianferno fabianferno self-assigned this Mar 12, 2025
Copy link

vercel bot commented Mar 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gap-app-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2025 2:32pm

Copy link
Contributor

@amaurymagalhaes amaurymagalhaes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems all good.

@fabianferno fabianferno merged commit ff1867e into dev Mar 17, 2025
2 checks passed
@fabianferno fabianferno deleted the feat/show-proof-on-charts branch March 17, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants