Skip to content

[Merged by Bors] - Correct bug in sync #2615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Correct bug in sync #2615

wants to merge 1 commit into from

Conversation

AgeManning
Copy link
Member

A bug that causes failed batches to continually download in a loop is corrected.

This was referenced Sep 23, 2021
Closed
Closed
@michaelsproul michaelsproul added bug Something isn't working ready-for-review The code is ready for review v2.0.0 Altair on mainnet release (v2.0.0) labels Sep 23, 2021
michaelsproul
michaelsproul approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this.

I'm also working on a Clippy lint so we can prevent it happening in future

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Sep 23, 2021
@AgeManning
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Sep 23, 2021
@AgeManning
Correct bug in sync (#2615)
9d0d709 
A bug that causes failed batches to continually download in a loop is corrected.
@bors
Copy link

bors bot commented Sep 23, 2021

Build failed:

@michaelsproul
Copy link
Member

bors retry

bors bot pushed a commit that referenced this pull request Sep 23, 2021
@AgeManning
Correct bug in sync (#2615)
00a7ef0 
A bug that causes failed batches to continually download in a loop is corrected.
@michaelsproul
Copy link
Member

Got my lint working 😎

error: casting function pointer `B::max_batch_download_attempts` to `usize`
   --> beacon_node/network/src/sync/range_sync/batch.rs:260:24
    |
260 |                     >= B::max_batch_download_attempts as usize
    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `B::max_batch_download_attempts() as usize`
    |
    = note: requested on the command line with `-D clippy::fn-to-numeric-cast-any`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#fn_to_numeric_cast_any

Clippy PR here: rust-lang/rust-clippy#7705

@bors
Copy link

bors bot commented Sep 23, 2021

Pull request successfully merged into unstable.

Build succeeded:

@bors bors bot changed the title Correct bug in sync [Merged by Bors] - Correct bug in sync Sep 23, 2021
@bors bors bot closed this Sep 23, 2021
@michaelsproul michaelsproul deleted the correct-sync branch September 23, 2021 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

Assignees
No one assigned
Labels
bug Something isn't working ready-for-merge This PR is ready to merge. v2.0.0 Altair on mainnet release (v2.0.0)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AgeManning @michaelsproul