Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SigningConfig #367

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

haydentherapper
Copy link
Contributor

Created a simple wrapper around the protobuf SigningConfig. I mirrored the existing code for TrustedRoot, though this is far simpler since this is just a few strings.

I didn't add support for ClientTrustConfig since we won't distribute this file via TUF, but this would be easy enough to add later on.

Fixes #185

Summary

Release Note

Documentation

@haydentherapper
Copy link
Contributor Author

We should hold off on merging til sigstore/protobuf-specs#451 is complete.

@haydentherapper haydentherapper marked this pull request as ready for review January 9, 2025 18:42
@haydentherapper haydentherapper requested a review from a team as a code owner January 9, 2025 18:42
codysoyland
codysoyland previously approved these changes Jan 9, 2025
Copy link
Member

@codysoyland codysoyland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks @haydentherapper!

Created a simple wrapper around the protobuf SigningConfig. I mirrored
the existing code for TrustedRoot, though this is far simpler since
this is just a few strings.

I didn't add support for ClientTrustConfig since we won't distribute
this file via TUF, but this would be easy enough to add later on.

Fixes sigstore#185

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
@haydentherapper
Copy link
Contributor Author

Conformance fixed, ready for another review.

Copy link
Member

@kommendorkapten kommendorkapten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@haydentherapper haydentherapper merged commit f62d7f4 into sigstore:main Jan 10, 2025
11 checks passed
@haydentherapper haydentherapper deleted the signing-config branch January 10, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for ClientTrustConfig
3 participants