Add support for SigningConfig #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should hold off on merging til sigstore/protobuf-specs#451 is complete. |
haydentherapper
force-pushed
the
signing-config
branch
from
03af4d5 to
cd57778
Compare
codysoyland
previously approved these changes
Jan 9, 2025
Created a simple wrapper around the protobuf SigningConfig. I mirrored the existing code for TrustedRoot, though this is far simpler since this is just a few strings. I didn't add support for ClientTrustConfig since we won't distribute this file via TUF, but this would be easy enough to add later on. Fixes sigstore#185 Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
haydentherapper
force-pushed
the
signing-config
branch
from
2ca5ccb to
6c8f5e4
Compare
Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
|
Conformance fixed, ready for another review. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a simple wrapper around the protobuf SigningConfig. I mirrored the existing code for TrustedRoot, though this is far simpler since this is just a few strings.
I didn't add support for ClientTrustConfig since we won't distribute this file via TUF, but this would be easy enough to add later on.
Fixes #185
Summary
Release Note
Documentation