Skip to content

GH Actions: various tweaks / PHP 8.2 not allowed to fail #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 9, 2022

Conversation

jrfnl
Copy link
Collaborator

@jrfnl jrfnl commented Dec 9, 2022

GH Actions: use PHP latest

... for those tasks where the PHP version isn't (or shouldn't be) that relevant.

Includes updating the task name to not include the PHP version (latest will roll on automatically).

GH Actions: minor simplification

... of the bash date command in the earlier pulled cache busting.

GH Actions: update PHP versions in workflows

PHP 8.2 has been released today 🎉 and the setup-php action has announced support for PHP 8.3, so adding PHP 8.3 to the matrix and no longer allowing PHP 8.2 to fail the build.

Note: PHPCS does not (yet) have full syntax support for PHP 8.2, but it does have runtime support (for the most part, see squizlabs/PHP_CodeSniffer#3629).

Builds against PHP 8.3 are still allowed to fail for now.

jrfnl added 3 commits December 9, 2022 01:52
... for those tasks where the PHP version isn't (or shouldn't be) that relevant.

Includes updating the task name to not include the PHP version (`latest` will roll on automatically).
... of the bash `date` command in the earlier pulled cache busting.
PHP 8.2 has been released today 🎉 and the `setup-php` action has announced support for PHP 8.3, so adding PHP 8.3 to the matrix and no longer allowing PHP 8.2 to fail the build.

Note: PHPCS does not (yet) have full syntax support for PHP 8.2, but it does have runtime support (for the most part, see squizlabs/PHP_CodeSniffer 3629).

Builds against PHP 8.3 are still allowed to fail for now.
@jrfnl
Copy link
Collaborator Author

jrfnl commented Dec 9, 2022

Note: looks like the latest version of Psalm is throwing two new issues. As far as I can see that's unrelated to this PR and needs a doc fix.

@sirbrillig sirbrillig merged commit f96c2ee into 2.x Dec 9, 2022
@sirbrillig sirbrillig deleted the feature/ghactions-tweaks branch December 9, 2022 18:59
@sirbrillig
Copy link
Owner

#286 should fix the Psalm issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants