New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix electron wallet cannot open explorer in browser #571

Merged

gz-c merged 1 commit into skycoin:develop from iketheadore:electron-open-explorer

Jul 4, 2019

Member

iketheadore commented Jul 2, 2019

The electron wallet will open a terminal when clicking the Skycoin Explorer.

Changes:

Run sehll.openExternal() like we did in skycoin electron wallet to
open the url in default browser when target = '_blank'.
Add .dockerignore to reduce the context size we send to docker daemon for building the docker
image.


          Fix the issue that electron failed to open explorer in browser

c756d8d

Instead it opens a terminal and do nothing

Senyoret1 approved these changes

View reviewed changes

Collaborator

Senyoret1 left a comment

👍

gz-c merged commit 4418545 into skycoin:develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet