Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PHP 7.4 allowed failure when Prophecy PR merged #126

Closed
l0gicgate opened this issue Aug 22, 2019 · 2 comments · Fixed by #131
Closed

Remove PHP 7.4 allowed failure when Prophecy PR merged #126

l0gicgate opened this issue Aug 22, 2019 · 2 comments · Fixed by #131

Comments

@l0gicgate
Copy link
Member

We need to remove 7.4 from the allow_failures array in the Travis config when phpspec/prophecy#432 is merged
@l0gicgate
Copy link
Member Author

The PR has been merged. This is an easy pick. Who wants it 😂

@theodorejb
Copy link
Contributor

A new release of phpspec/prophecy has to be published first.

theodorejb added a commit to theodorejb/Slim-Psr7 that referenced this issue Oct 3, 2019
@theodorejb
Require tests to pass on PHP 7.4 now that phpspec/prophecy is compatible
d690590 
Closes slimphp#126
@theodorejb theodorejb mentioned this issue Oct 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Require tests to pass on PHP 7.4 now that phpspec/prophecy is compatible theodorejb/Slim-Psr7
2 participants
@theodorejb @l0gicgate