Fix test ServerRequestTest::testGetUploadedFiles

[danopz]

Fixed an unit tests which was suddenly failing on my local machine for reason:

There was 1 error:

1. Slim\Tests\Psr7\Integration\ServerRequestTest::testGetUploadedFiles
   RuntimeException: Could not create Stream. Check your config

/data/workspace/Slim-Psr7/vendor/php-http/psr7-integration-tests/src/BaseTest.php:111
/data/workspace/Slim-Psr7/vendor/php-http/psr7-integration-tests/src/ServerRequestIntegrationTest.php:83

[coveralls]

Coverage remained the same at 99.731% when pulling 223117a on danopz:fix-unit-test into 8066cee on slimphp:master.

[akrabat]

@danopz That's a fairly significant change. Any idea why?

[danopz]

@akrabat in general I can't tell why it was working before. As far as I can see there was no change in either of both libraries which changed some behaviour for this, so it should have been failing before.

protected function buildUploadableFile($data)
{
    if (defined('UPLOADED_FILE_FACTORY')) {
        $factoryClass = UPLOADED_FILE_FACTORY;
        $factory = new $factoryClass();
        if (!$factory instanceof \Psr\Http\Message\UploadedFileFactoryInterface) {
            throw new \RuntimeException('Constant "UPLOADED_FILE_FACTORY" must be a reference to a Psr\Http\Message\UploadedFileFactoryInterface');
        }

        $stream = $this->buildStream($data);

        return $factory->createUploadedFile($stream);
    }

    if (class_exists(GuzzleUploadedFile::class)) {
        return new GuzzleUploadedFile($data, strlen($data), 0);
    }

    if (class_exists(ZendUploadedFile::class)) {
        return new ZendUploadedFile($data, strlen($data), 0);
    }

    throw new \RuntimeException('Could not create Stream. Check your config');
}

Thats the function we want to overwrite here since we want to create our own objects for the tests. As it looks we (or I?) wrote a createUploadedFile like the one which is called from the UPLOADED_FILE_FACTORY.
But because we didn't use the constants here for setting own factories this function should have always thrown the error.