Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add header with empty array value must throw exception #119

Merged
merged 6 commits into from
Aug 7, 2019
Merged

Add header with empty array value must throw exception #119

merged 6 commits into from
Aug 7, 2019

Conversation

mapogolions
Copy link
Contributor

Abstract class Message can detect the specified error, because directly calls static methods Headers::validateHeaderName and Headers::validateHeaderValue. Headers class cannot do the same due to improper operation of the method validateAndTrimHeader.

@coveralls
Copy link

coveralls commented Aug 6, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.001%) to 99.732% when pulling af1b37b on mapogolions:fix/headers-with-empty-array-value into 0771c73 on slimphp:master.

@l0gicgate l0gicgate added this to the 0.5 milestone Aug 6, 2019
@l0gicgate l0gicgate requested a review from adriansuter August 6, 2019 21:23
@adriansuter
Copy link
Contributor

I will review tomorrow.

adriansuter
adriansuter reviewed Aug 7, 2019
View reviewed changes
@l0gicgate l0gicgate merged commit 3b8dc24 into slimphp:master Aug 7, 2019
@mapogolions mapogolions deleted the fix/headers-with-empty-array-value branch August 7, 2019 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriansuter adriansuter adriansuter approved these changes

@l0gicgate l0gicgate l0gicgate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5
Development

Successfully merging this pull request may close these issues.
4 participants
@mapogolions @coveralls @adriansuter @l0gicgate