Add support for PHP 7.4 #125
Merged
+33
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this a WIP? If so please label the title with [WIP]. Please fix PHP Stan errors as well |
theodorejb
force-pushed
the
support-php-7.4
branch
from
8bf4d83 to
88a7ec4
Compare
|
This isn't a WIP anymore. I fixed the PHPStan errors. |
|
We need to add PHP 7.4 to the travis config also, so we can see if the build passes for that version |
theodorejb
force-pushed
the
support-php-7.4
branch
2 times, most recently
from
915e49f to
bd10c4a
Compare
In PHP 7.4 errors are reported for stream read and write operations per php/php-src@d59aac5.
theodorejb
force-pushed
the
support-php-7.4
branch
from
bd10c4a to
5cb4871
Compare
|
I had to allow failures for PHP 7.4 in Travis. One test fails since phpspec/prophecy#432 hasn't been merged yet. |
We'll have to make sure we update prophecy as soon as that's merged and remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PHP 7.4 errors are reported for stream read and write operations per
php/php-src@d59aac5.
Tested with PHP 7.4 beta 4.