Backports for 1.4.x #325
Merged
Backports for 1.4.x #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.4 removes PHP 7.2 support
v1 supports PHP 7 v2 supports PHP 8
(cherry picked from commit 36998c9)
(cherry picked from commit 501b60f)
(cherry picked from commit 509df95)
(cherry picked from commit e17e0eb)
To avoid `PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy"`.
Userinfo that is already encoded should not be encoded twice. Fixes `testAlreadyEncodedUserInfo` from the updated psr7-integration-tests.
As per the updated psr7-integration-tests, we need to ensure that when a path is used in isolation from the authority, it will not cause URL poisoning and/or XSS issues. See https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2015-3257
This comment was marked as resolved.
This comment was marked as resolved.
This was referenced Mar 18, 2025
Merged
Merged
akrabat
added a commit
that referenced
this pull request
Mar 23, 2025
Backports for 1.5.x - Add support for PHP 8.4 by @williamdes in #325 - Fixed: Uri::getPath() correctly normalises leading slashes. - Fixed: Uri no longer double encodes user info.
akrabat
added a commit
that referenced
this pull request
Mar 23, 2025
Backports for 1.6.x - Add support for PHP 8.4 by @williamdes in #325 - Fixed: Uri::getPath() correctly normalises leading slashes. - Fixed: Uri no longer double encodes user info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See last test run: https://github.com/williamdes/Slim-Psr7/actions/runs/13876256748
New integration tests to be fixed: #324 (comment)
Probably not related to this PR, but will have to be done for CI to pass
Fixes: #324