4.x Remove App Settings

[l0gicgate]

Remove App settings and associated tests as per discussion @akrabat via Slack.

We have removed all of the settings from the App. The customization that those settings provided are now available in the instantiation of core middleware or the logic to apply those settings has changed.

The settings deprecated:

• httpVersion This can be set via your PSR-7 implementation's ResponseFactory if available
• routerCacheFile You have to get the router via App::getRouter() then $router->setCacheFile($file)
• displayErrorDetails is now moved to ErrorMiddleware's constructor parameters
• outputBuffering is now moved to OutputBufferingMiddleware's constructor parameters
• determineRouteBeforeAppMiddleware is now moved to order in which you add RoutingMiddleware
• responseChunkSize is moved to ResponseEmitter's constructor parameters
• addContentLengthHeader is defined by whether or not you add ContentLengthMiddleware to your middleware queue

Will need to update CHANGELOG

[coveralls]

Coverage decreased (-0.009%) to 99.41% when pulling 12ff350 on l0gicgate:4.x-RemoveSettings into 5311e95 on slimphp:4.x.

[froschdesign]

@l0gicgate

…as per discussion @akrabat

Unfortunately, this information is useless because nobody knows where to find this discussion. It would be better to publish a summary and the result of the discussion. A link reference would also be sufficient.

[l0gicgate]

would be better to publish a summary and the result of the discussion. A link reference would also be sufficient.

Fair point, it's just that not all discussions happen via the GitHub repository. We have a private channel on Slack where we have some internal discussions.

I do agree though that it should maybe be discussed in issues instead of on our private channel. I apologize for that.

[akrabat]

Conversation was on Slack. See https://slimphp.slack.com/messages/C06SHUR19/

…

On 23 Feb 2019, at 07:51, Frank Brückner ***@***.***> wrote: @l0gicgate <https://github.com/l0gicgate> …as per discussion @akrabat <https://github.com/akrabat> Unfortunately, this information is useless because nobody knows where to find this discussion. It would be better to publish a summary and the result of the discussion. A link reference would also be sufficient. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2589 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACBb94lWlOCaJZl7ChKrgmQWiRcuqACks5vQPLvgaJpZM4bMv5L>.

-- Development thoughts at http://akrabat.com Daily Jotter for macOS at http://dailyjotter.com

[l0gicgate]

@akrabat @froschdesign I just added the details in the description of this PR as well.

[froschdesign]

@l0gicgate @akrabat
Please do not misunderstand me, this is only a hint that referring to a (private) discussion without details or link in a public issue tracker does not work.

[l0gicgate]

@l0gicgate @akrabat
Please do not misunderstand me, this is only a hint that referring to a (private) discussion without details or link in a public issue tracker does not work.

I completely agree, I will make sure going forward that everything is documented here as much as possible if we do have internal discussions. I normally open issues so we can track it, in this instance I did not and I should have. My apologies.

[akrabat]

Will need to update CHANGELOG

Please update the CHANGELOG :)

[l0gicgate]

Please update the CHANGELOG :)

Done @akrabat