-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
non-buffered responses fixes #2673
Conversation
- Fix non buffered responses when calling Response::withAddedHeader() and Response::withoutHeader()
Can you PR this on Slim PSR-7 as well please? Also we should add tests cases for the newly introduced code. |
The merged PR against slim/psr7 that I referenced in the first comment already has these fixes. Also, regarding the difficulty of testing this feature: #2504 (comment) Unfortunately neither of the 2 original PRs had any (real) tests for this. |
…ting bootstrap file
That'd be it. I've done some cleanup in the testing autoloading, too. These overrides should only be loaded from tests/bootstrap.php, not at each |
Reference: slimphp/Slim-Psr7#39 (comment)