Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-buffered responses fixes #2673

Merged
merged 3 commits into from
Apr 30, 2019
Merged

non-buffered responses fixes #2673

merged 3 commits into from
Apr 30, 2019

Conversation

1ma
Copy link

@1ma 1ma commented Apr 29, 2019

  • Fix potential casting from array to string in Response::withHeader()
  • Fix non buffered responses when calling Response::withAddedHeader() and Response::withoutHeader()

Reference: slimphp/Slim-Psr7#39 (comment)

- Fix non buffered responses when calling Response::withAddedHeader() and Response::withoutHeader()
@coveralls
Copy link

coveralls commented Apr 29, 2019

Coverage Status

Coverage increased (+0.3%) to 97.606% when pulling 6914d32 on 1ma:fix-nonbuffer-headers into e6f75e8 on slimphp:3.x.

@l0gicgate
Copy link
Member

Can you PR this on Slim PSR-7 as well please? Also we should add tests cases for the newly introduced code.

@l0gicgate l0gicgate added this to the 3.12.2 milestone Apr 29, 2019
@1ma
Copy link
Author

1ma commented Apr 29, 2019

The merged PR against slim/psr7 that I referenced in the first comment already has these fixes. Also, regarding the difficulty of testing this feature: #2504 (comment)

Unfortunately neither of the 2 original PRs had any (real) tests for this.

@1ma
Copy link
Author

1ma commented Apr 30, 2019

That'd be it. I've done some cleanup in the testing autoloading, too. These overrides should only be loaded from tests/bootstrap.php, not at each composer install. Now to port these new tests back to Slim-Psr7...

@l0gicgate
Copy link
Member

I'm somewhat worried we might break some builds in the wild as seen in #2669 because we're moving the assets into bootstrap.php but I guess we'll have to deal with it when the issues come in. Great work @1ma!

@l0gicgate l0gicgate merged commit ccef5f7 into slimphp:3.x Apr 30, 2019
@1ma 1ma deleted the fix-nonbuffer-headers branch April 30, 2019 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants