test: use isolated, temporary GIT_CONFIG
#420
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the unit tests were changing the configuration in
.git/config
. They also read user configuration as fallback values, which made things verifying correct behaviour confusing—especially when some user configuration matches the defaults!(Although there was a specific guard checking against
in_unit_test
, that was only for boolean config values, not configuration in general).This generates a gitconfig in
$BATS_TMPDIR
and exports bothGIT_CONFIG=…
andGIT_CONFIG_NOSYSTEM=1
, whichgit
will respect for isolating that configuration.That setup and teardown is done in
setup_file
(once per suite, rather than once per test). Some other test setup has been moved into those bat callbacks as well.