test: use isolated, temporary GIT_CONFIG
#420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll rebase this on common base of |
This writes a temp git config file during setup/teardown, and exports GIT_CONFIG=… to that and sets GIT_CONFIG_NOSYSTEM=1. This ensures that any git invocations _only_ use that configuration. Note that none of the tests currently test anything other than the default config; however, if they do, the generation of this test config should be moved into `setup()` rather than `setup_file()` so that it can be modified and restored between tests.
|
Done; this now targets |
|
This looks cool. I've been wanting to implement something like this for a while, but never had the time. I don't totally understand all of it, so if something breaks down the line (the tests all pass right now) I may have to poke you to help fix things. Great work. |
|
Well... maybe I spoke too soon? I merge it, and now some tests are failing? |
|
I'm not seeing the failure, do you have a link? |
|
@rwe false alarm I guess. My local branch had failing tests. When I did a clean checkout all the tests pass. I must have messed up my local branch somehow. We're good. Nothing to see here. Move along :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the unit tests were changing the configuration in
.git/config. They also read user configuration as fallback values, which made things verifying correct behaviour confusing—especially when some user configuration matches the defaults!(Although there was a specific guard checking against
in_unit_test, that was only for boolean config values, not configuration in general).This generates a gitconfig in
$BATS_TMPDIRand exports bothGIT_CONFIG=…andGIT_CONFIG_NOSYSTEM=1, whichgitwill respect for isolating that configuration.That setup and teardown is done in
setup_file(once per suite, rather than once per test). Some other test setup has been moved into those bat callbacks as well.