fix: over-permissive regex for added/deleted file meta header #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR also looks good. I just noticed that last PR was against Per our contribution guidelines, all PRs should be against |
|
@scottchiefbaker Ah, I missed that, thanks! It looks like the Would you prefer I create PRs for those two branches into For this one, I think I can just rebase it back to the common base (i.e. not including the npm flatpack PR). |
The previous pattern uselessly included `.*`, unlike all the other patterns, and so would erroneously match on actual diff content lines. Noticed this because the line itself was filtered out of diffs in this codebase. This also tightens the pattern since the file mode will always be six octal (0-7) chars; and in the git codebase the format string is: "%s%snew file mode %06o%s\n"
rwe
force-pushed
the
fix-file-meta-regex
branch
from
a584a20 to
fc8e7ee
Compare
|
This PR now targets |
|
Excellent thanks for the simple concise diff. Makes my job a lot easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this because the line itself was filtered out of diffs in this codebase.
The previous pattern uselessly included
.*, unlike all the other patterns, and so would erroneously match on actual diff content lines.This also tightens the pattern since the file mode will always be six octal (0-7) chars; and in the git codebase the format string is:
"%s%snew file mode %06o%s\n".