test(server): extend Lobby testing #363
Conversation
xeruf
force-pushed
the
test/lobbyrequests
branch
from
6b26a13 to
1ebee7c
Compare
|
RequestTest has just become a lot more manageable and reliable 🎉 |
xeruf
force-pushed
the
test/lobbyrequests
branch
from
1ebee7c to
e119dc4
Compare
|
whoopsie - apparently some tests stopped running, that's why it all looks so smooth -.- junit-team/junit5#1914 |
xeruf
force-pushed
the
test/lobbyrequests
branch
from
2bfda1a to
2fccc89
Compare
|
I've started embracing fancy Kotest matchers with which the tests and failures finally made sense to me ;) |
xeruf
force-pushed
the
test/lobbyrequests
branch
from
3f52c57 to
01f92dc
Compare
xeruf
force-pushed
the
test/lobbyrequests
branch
from
474d841 to
269bdd5
Compare
|
This is getting quite big, but I guess I'll go with it - the tests are still not fully fixed |
xeruf
force-pushed
the
test/lobbyrequests
branch
from
269bdd5 to
de33c36
Compare
|
oh yeah, it's all working! |
| val playerListeners = room.slots.map { slot -> | ||
| PlayerListener().also { listener -> slot.role.player.addPlayerListener(listener) } | ||
| } | ||
| "start game on unpause" { |
There was a problem hiding this comment.
How about testing what happens if the paused game receives moves? I guess that would terminate the game?
There was a problem hiding this comment.
it should just behave like any case in which a move is sent without request: the game is canceled with an appropriate error. But yes, maybe that should have a test.
xeruf
force-pushed
the
test/lobbyrequests
branch
from
de33c36 to
74a9182
Compare
the aim is to consolidate it with the other tests (i.e. RequestTest and the like) and expand coverage
based on #382 because that solves some precursive issues