Fix stoi error when passing --jobs=auto in non-OpenMP code path #2477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2477 +/- ##
==========================================
- Coverage 77.79% 77.79% -0.01%
==========================================
Files 492 492
Lines 33188 33189 +1
==========================================
Hits 25818 25818
- Misses 7370 7371 +1
|
quentin
reviewed
Mar 15, 2024
|
Yeah, let me rewrite this a little bit. |
When passing `auto` to the jobs in non-OpenMP mode, the `"auto"` ends up as an argument to `std::stoi` in a couple of places, causing the program to crash. We fix this by mapping `auto` to `1` when OpenMP is not available. Fixes souffle-lang#2475
strRM
force-pushed
the
rm/cet-2475-fix-stoi-no-conversion
branch
from
0ee65f8 to
f58f4c2
Compare
|
I don't like the 2 ifdefs. I suppose I could introduce a boolean variable |
quentin
approved these changes
Mar 15, 2024
|
I assume you're aware of the failures due to running out of disk space? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing
autoto the jobs in non-OpenMP mode, the"auto"ends up as an argument tostd::stoiin a couple of places, causing the program to crash. We fix this by mappingautoto1when OpenMP is not available.Fixes #2475