Skip to content

added sound and plotly to modulesAvailableForC so CTOWASM is able to access these modules #3132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

morpheuschoo
Copy link

@morpheuschoo morpheuschoo commented May 11, 2025

Description

Addition of sound and plotly to modulesAvailableForC such that CTOWASM is able to access these functions from the Modules repository and use them.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

#include <sound>
#include <plotly>

// no error occurs

Checklist

  • I have tested this code

@coveralls
Copy link

Pull Request Test Coverage Report for Build 14959280498

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 31.004%

Totals Coverage Status
Change from base Build 14851045635: 0.0%
Covered Lines: 4892
Relevant Lines: 14883

💛 - Coveralls

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is blocked by the c-slang PR right? Meaning we need to update c-slang dependency first?

@morpheuschoo
Copy link
Author

@RichDom2185 No this PR has to be pushed first then the c-slang PR can be pushed.

This PR loads in the modules sound and plotly to c-slang so that we can call the functions from these modules in c-slang.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants