SymPy 1.12 #1256
Merged
SymPy 1.12 #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… symbols and filter out Callables and Iterables.
tbennun
requested changes
May 17, 2023
tbennun
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for compatibility with SymPy 1.12.
The main issue concerns symbolic substitution. In SymPy 1.12, the new values are sympified with
strict=True,which allows the sympification of only scalar values (noNonevalues,Callables.Iterables, and strings). This PR addressed the issue in the following manner:Nonevalues,Callables, andIterables are filtered out from the replacement dictionaries since it is unlikely that their corresponding old values need to be replaced.sympy.symbols since they should be symbol names.