Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-picks tensor-related libraries/replacements #1309

Merged
merged 33 commits into from
Jul 16, 2023
Merged

Cherry-picks tensor-related libraries/replacements #1309

merged 33 commits into from
Jul 16, 2023

Conversation

alexnick83
Copy link
Contributor

@alexnick83 alexnick83 commented Jul 11, 2023 •
edited
Loading

Ports TensorTranspose and TensorDot to the master branch to continue developing tensor-related libraries.

alexnick83 added 27 commits July 11, 2023 11:44
@alexnick83
Working on tensor-transpose library.
767557d
@alexnick83
Small fixes in pure expansion of TensorTranspose.
c8291dc
@alexnick83
Improvements to numpy transpose replacement to follow numpy semantics.
c569286
@alexnick83
Added HPTT expansion.
459e07c
@alexnick83
Added ttranspose library to the configuration schema.
f272b05
@alexnick83
Added HPTT tests.
ba77a1f
@alexnick83
Added TypeError exception for unsupported datatypes.
c0dbfa2
@alexnick83
Started working on TensorDot library node (see numpy linalg).
9bb00a9
@alexnick83
Added tensor-dot pure expansion.
1e0a3cd
@alexnick83
Added tensordot replacement.
8b73eb0
@alexnick83
Minor fixes.
79f37fc
@alexnick83
Added first tensordot test.
9e5cab7
@alexnick83
Added second tensordot test.
1ca95d3
@alexnick83
Added TTGT implementation.
3511ece
@alexnick83
Small fixes.
f7b589c
@alexnick83
Added tests for TTGT expansion.
970128d
@alexnick83
TTGT expansion of TensorDot will now use the transA and transB parame…
ead72c1 
…ters of GEMM when possible.
@alexnick83
Linalg library doesn't have environments.
251e7f6
@alexnick83
Added special case where TensorTranspose can be resolved as MatrixTra…
ecaffd7 
…nspose.
@alexnick83
Fixed row/col computation
4804abe
@alexnick83
Started working on cuTENSOR and ExpandCuTensor for TensorDot.
5b66cf0
@alexnick83
ExpandCuTensor compiles
e838341
@alexnick83
Fixed strides in cuTENSOR tensordot.
ad53fe2
@alexnick83
Small fixed for cuTENSOR.tensordot
3221aad
@alexnick83
libcutensor.lib must now be on the user's (LD_)LIBRARY_PATH
1dddd8f
@alexnick83
Enabled optional and non-standard extension to numpy.tensordot that…
fbefd88 
… allows permutation of the output.
@alexnick83
Clean-up
3ba8499
@alexnick83 alexnick83 marked this pull request as ready for review July 11, 2023 11:35
@alexnick83 alexnick83 requested a review from tbennun July 11, 2023 11:35
tbennun
tbennun requested changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@tbennun tbennun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good except for one thing: I think tensor transpose should live somewhere else (standard/blas/linalg) rather than a ttranspose library of its own

@alexnick83 alexnick83 requested a review from tbennun July 15, 2023 11:30
tbennun
tbennun approved these changes Jul 15, 2023
View reviewed changes
Copy link
Collaborator

@tbennun tbennun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@tbennun tbennun enabled auto-merge July 16, 2023 01:43
@tbennun tbennun merged commit a2cb57f into master Jul 16, 2023
@alexnick83 alexnick83 deleted the port-tensor-related-library-nodes branch July 16, 2023 09:32
@BenWeber42 BenWeber42 mentioned this pull request Oct 27, 2023
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbennun tbennun tbennun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexnick83 @tbennun