Fix array indirection to memlet subset promotion #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenWeber42
commented
Oct 31, 2023
BenWeber42
force-pushed
the
fix-advanced-free-symbols
branch
from
31b15c3 to
8946323
Compare
BenWeber42
commented
Sep 18, 2024
tests/double_index_bug_test.py
Outdated
| from dace import subsets | ||
|
|
||
|
|
||
| def test_double_index_bug(): |
There was a problem hiding this comment.
Maybe I should put this test somewhere else? 🤔
There was a problem hiding this comment.
Probably in tests/passes/scalar_to_symbol_promotion_test.py?
tbennun
approved these changes
Sep 23, 2024
tests/double_index_bug_test.py
Outdated
| from dace import subsets | ||
|
|
||
|
|
||
| def test_double_index_bug(): |
There was a problem hiding this comment.
Probably in tests/passes/scalar_to_symbol_promotion_test.py?
tests/double_index_bug_test.py
Outdated
| @@ -0,0 +1,48 @@ | |||
| # Copyright 2019-2023 ETH Zurich and the DaCe authors. All rights reserved. | |||
tbennun
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current solution is rather hacky. I want to run the tests first to see the impacts of this change.
Additionally, there is no test yet, because validation doesn't catch the erroneous SDFG yet.
Overall, it's not clear currently how to solve the issue and the PR might change as we progress...