-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Subsetlist and covers_precise #1412
Implement Subsetlist and covers_precise #1412
Conversation
Thank you for the contribution. Before reviewing the PR, I have a minor naming comment: perhaps UnionSubset is a better name? |
I renamed it |
Seems like |
It looks like DaCe is still installing SymPy 1.9, and that might be the reason: https://github.com/spcl/dace/actions/runs/6706005794/job/18223680540?pr=1412#step:4:521 Maybe try changing setup.py to reflect that ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! Please make it clear what all the tests are testing.
c0b4264
to
1e83e71
Compare
Now the test should work. |
|
862eea9
to
ab11b20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now! Thank you!
This PR adds new functionality to the
Subset
classSubsetlist
is a new Subset that acts as a wrapper of existing subset types. It is essentially a list of Subset objects. The union of two Subsetlists is just the list concatenation.covers_precise()
implements a set cover operation on Subsets of type Range and Indices. If it returns true the first input subset definitely covers the second input subset. Therefore it also takes steps into account.