Fix for VS Code debug console: view opens sdfg in VS Code and not in browser #1419
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
phschaad
requested changes
Nov 1, 2023
dace/cli/sdfv.py
Outdated
| @@ -36,7 +36,7 @@ def view(sdfg: dace.SDFG, filename: Optional[Union[str, int]] = None): | |||
| """ | |||
| # If vscode is open, try to open it inside vscode | |||
| if filename is None: | |||
| if 'VSCODE_IPC_HOOK_CLI' in os.environ or 'VSCODE_GIT_IPC_HANDLE' in os.environ: | |||
| if 'VSCODE_IPC_HOOK' in os.environ or 'VSCODE_GIT_IPC_HANDLE' in os.environ: | |||
There was a problem hiding this comment.
I just checked - in my environment (Ubuntu20), VSCode does not set the VSCODE_IPC_HOOK variable in the terminal, nor the debug console, weirdly enough. In that case I would request that we test for both VSCODE_IPC_HOOK and VSCODE_IPC_HOOK_CLI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test system Mac OS
This small modification makes sure that in both modes (interactive & debug) the
sdfg.view()will open the graph in the VS Code env (if present) and not in the available browser.The
VSCODE_IPC_HOOK_CLIenv var is present in an interactive session from the VS Code termninal, but it is not present in the debug console. In the debugging mode, it is theVSCODE_IPC_HOOKenv var which is present.