-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DeadDataFlowElimination
will add type hint when removing a connector
#1499
Conversation
…le which are removed by DeadDataflowElimination
@tbennun can you please approve the workflows? |
Thank you for the PR! Unfortunately our CI is currently undergoing fixing so failing tests may not mean that your PR broke them. |
@luca-patrignani as for your questions:
|
@tbennun can you please approve the workflows once again? |
@tbennun when you have some free time can we continue this PR review? |
@luca-patrignani please stop merging the master branch to this one. When merging the PR, we will squash and merge the updated version as necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you again for contributing this fix!
Issue #1150 that
DeadDataflowElimination
removes a connector from a Tasklet which leaves a variable without type hint.This PR tries to fix this bug by adding a type hint expression for a variable which is used in the tasklet. It adds the type hint only if the variable is used inside the tasklet code (I checked using
ASTFindReplace
).The PR also adds a test which is literaly the code presented in #1150 and asserts the presence of the type hint and checks if it compiles.
May need confirmation
ASTFindReplace
correctly?This is my first PR for this project so be patient with me.