Support output indirection in numpy frontend #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexnick83
reviewed
Jan 22, 2024
There was a problem hiding this comment.
It looks good, but before I approve, can you confirm that the implementation conforms to the warning at the beginning of NumPy's advanced indexing documentation? I can help write a set of appropriate tests later this week.
That should be fine as it is an AST-level difference. I will add a test though. |
|
@alexnick83 Added the test you requested and fixed some bugs along the way. Ready for rereview. |
alexnick83
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports expressions such as
a[indices] = b