Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize HIP CMake commands, fix corner cases #1518

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Modernize HIP CMake commands, fix corner cases #1518

merged 3 commits into from
Feb 19, 2024

Conversation

tbennun
Copy link
Collaborator

@tbennun tbennun commented Feb 13, 2024

Enables support for newer HIP versions with CMake, fix branch ordering when making data descriptors.

@tbennun tbennun requested a review from phschaad February 13, 2024 18:09
phschaad
phschaad approved these changes Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@phschaad phschaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity, what was the issue with respect to the data construction ordering?

@tbennun
Copy link
Collaborator Author

tbennun commented Feb 14, 2024

Just out of curiosity, what was the issue with respect to the data construction ordering?

PyTorch tensors expose __*_array_interface__ but fail to actually retrieve it.

@tbennun tbennun added the in the merge queue waiting for CI to work again label Feb 14, 2024
@tbennun tbennun enabled auto-merge February 16, 2024 01:37
auto-merge was automatically disabled February 16, 2024 16:42

Merge queue setting changed

@tbennun tbennun merged commit f28e960 into master Feb 19, 2024
11 checks passed
@tbennun tbennun deleted the hip-modernize-cmake branch February 19, 2024 01:52
@tbennun tbennun restored the hip-modernize-cmake branch February 19, 2024 01:52
@tbennun tbennun deleted the hip-modernize-cmake branch February 19, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phschaad phschaad phschaad approved these changes

Assignees
No one assigned
Labels
in the merge queue waiting for CI to work again
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbennun @phschaad