Updated and fixed the MapExpansion transformation. #1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the transformation ignored the tiling parameter of the range, this was fixed. The transformation is now also able to limit the expansion. Thus it is possible to only expand the first k dimensions, the remaining dimensions will be kept in a multi dimensional map. This is a feature that will be need in GT4Py.
The computation of the new maps is now its own function, which allows subclassing. In addition now the schedule of teh first map is explicitly set, before there was a slight error, that was, however, not important because the value was not used.
This commit makes it a bit more verbose, hope this helps me to debug it.
…lso seems that nothing was in the state. Now be even more verbose and explore everything.
It seems that there is an init state on the CI which is not present on my machine. This commit actually fixes a bug in the test.
There was a problem hiding this comment.
The PR itself looks good, but the question is whether this is needed:
- One goal is to have simple, composable transformations, e.g., MapExpansion+MapCollapse.
- The tile size parameter should be deprecated IMO and users should use MapTiling or StripMining which creates explicit maps? The parameter is not considered during dataflow analysis
Now Simplify is called on the SDFG. This idea was actually suggested by @lukastruemper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the transformation ignored the tiling parameter of the range, this was fixed. The transformation is now also able to limit the expansion. Thus it is possible to only expand the first k dimensions, the remaining dimensions will be kept in a multi dimensional map.
This is a feature that will be need in GT4Py.