Add dtype for numpy.uintp which is compatible with C uintptr_t #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexnick83
approved these changes
Mar 8, 2024
tbennun
approved these changes
Mar 8, 2024
tbennun
requested changes
Mar 11, 2024
tbennun
reviewed
Mar 11, 2024
alexnick83
approved these changes
Mar 13, 2024
|
@tbennun is it ok to merge? |
|
No. The test is not portable (assumes g++ exists, assumes /tmp exists, assumes Linux) and too elaborate for what it should test. It also leaks 4 bytes. I’ll make a simple test myself and edit your branch if you don’t mind |
more than welcome to suggest another test. |
|
@kotsaloscv see new test |
tbennun
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need this to pass C pointers to DaCe sdfg and reinterpret cast them inside a tasklet