Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UUIDs to SDFG elements #1631

Merged
merged 7 commits into from
Aug 28, 2024
Merged

Add UUIDs to SDFG elements #1631

merged 7 commits into from
Aug 28, 2024

Conversation

phschaad
Copy link
Collaborator

No description provided.

@tbennun
Copy link
Collaborator

tbennun commented Aug 26, 2024

The diff looks good, the error is weird (because super().__init__() is called). I would refactor the uuid function to a central location so that it is configurable (e.g., for determinism).

@phschaad
Copy link
Collaborator Author

phschaad commented Aug 27, 2024

I tried debugging the error a bit and I am genuinely super confused what is going on here. It doesn't even matter what I name the property, it really is like it is never defined for some instances of objects, but it is for others - despite super().__init__() seemingly being called everywhere, as you state.

@phschaad
Copy link
Collaborator Author

It's __deepcopy__...

@phschaad phschaad marked this pull request as ready for review August 27, 2024 11:57
@phschaad phschaad mentioned this pull request Aug 27, 2024
@tbennun
Copy link
Collaborator

tbennun commented Aug 27, 2024

@phschaad so we already have a validation check that tests the uniqueness of id(obj) for objects for bad references. I wonder if we should also verify that for obj.id (probably secondary)

@phschaad phschaad requested a review from tbennun August 28, 2024 12:05
@phschaad phschaad requested a review from tbennun August 28, 2024 13:08
Copy link
Collaborator

@tbennun tbennun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great addition!

@tbennun tbennun enabled auto-merge August 28, 2024 14:16
@tbennun tbennun added this pull request to the merge queue Aug 28, 2024
Merged via the queue into master with commit d3a1c57 Aug 28, 2024
10 checks passed
@tbennun tbennun deleted the sdfg_guid branch August 28, 2024 17:30
github-merge-queue bot pushed a commit that referenced this pull request Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants