Specified behaviour of Subset.covers() for different dimensionality
#1637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before all cover functions ignored the case if the subsets have different lengths.
The effect was that the subsets `A = Range.from_string("i, k, 0:N, 1")` and `B = Range.from_string("i, k")` would cover each other.
This case was considered undefined behaviour.
This commit changes the behaviour of these function such that for covering it is required that the subsets must have the same dimensions.
tbennun
requested changes
Sep 4, 2024
Thanks for your suggestions. Co-authored-by: Tal Ben-Nun <tbennun@users.noreply.github.com>
tbennun
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before all cover functions ignored the case if the subsets have different lengths. The effect was that the subsets
A = Range.from_string("i, k, 0:N, 1")andB = Range.from_string("i, k")would cover each other. This case was considered undefined behaviour.This commit changes the behaviour of these function such that for covering it is required that the subsets must have the same dimensions.