Maps With Zero Parameters #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is now able to cleanly handle the case of dynamic map ranges. In that case the map is no longer removed, but one map parameter is added back, whcih is needed for syntactical reasons. Furthermore, the transformation will now ignore GPU maps, this is because they may be needed for purly syntactical reasons.
The transformation is in fact useless as it does a subset of what `TrivialMapEleimination` does. Furthermore, that thing had an error, as it was never cheking if an elimination of all trivial map ranges would lead to an empty map that must be removed.
tbennun
requested changes
Sep 11, 2024
|
Tiny change before merging |
Co-authored-by: Tal Ben-Nun <tbennun@users.noreply.github.com>
tbennun
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before a map without any parameter was considered not invalid, it would pass validation, but most likly compilation would fail (except it is a serial map).
This PR adds:
Mapobject.TrivialMapEliminationsuch that it correctly handles the case if it has dynamic map ranges.TrivialMapRangeEliminationtransformation as it is redundant and contained a bug.