[f2dace/dev, fortran] Necessary changes for solve_nh graph.
#1969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pratyai
force-pushed
the
solve_nh
branch
9 times, most recently
from
0333e34 to
0f2fd68
Compare
diff --git c/dace/frontend/fortran/ast_transforms.py i/dace/frontend/fortran/ast_transforms.py
index f50d1fe44..7bdaf013f 100644
--- c/dace/frontend/fortran/ast_transforms.py
+++ i/dace/frontend/fortran/ast_transforms.py
@@ -1180,7 +1180,7 @@ class ScopeVarsDeclarations(NodeVisitor):
return self.module_declarations[variable_name]
else:
raise RuntimeError(
- f"Couldn't find the declaration of variable {variable_name} in function {self._scope_name(scope)}!")
+ f"Couldn't find the declaration of variable {variable_name} in function {self._scope_name(scope) if scope else scope}!")
def contains_var(self, scope: ast_internal_classes.FNode, variable_name: str) -> bool:
return (self._scope_name(scope), variable_name) in self.scope_vars
@@ -1199,7 +1199,7 @@ class ScopeVarsDeclarations(NodeVisitor):
def _scope_name(self, scope: ast_internal_classes.FNode) -> str:
if isinstance(scope, ast_internal_classes.Main_Program_Node):
- return scope.name.name.name
+ return scope.name.name
elif isinstance(scope, str):
return scope
else:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.