Updated MultistateInlining #1980
Merged
+891
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philip-paul-mueller
added a commit
to philip-paul-mueller/gt4py
that referenced
this pull request
Mar 19, 2025
This [issue](spcl/dace#1959) leaded to some problem, especially in ICON4Py stencil `39_to_40`. However, through an [update](GridTools#1915) in GT4Py this leads to now to other problems (`ConstantPropagation` involving AcccessNodes) in `19_to_20`. The underlying issue in DaCe was solved in [PR#1980](spcl/dace#1980) and this PR now deactivate the workaround. Only merge if the DaCe dependency in GT4Py was updated to include that fix.
acalotoiu
approved these changes
Mar 19, 2025
phschaad
approved these changes
Mar 19, 2025
|
Weird failing test - can that be reproduced locally? It seems like a possible missing reshape / view when inlining, but seems a bit strange that only one test fails then. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
philip-paul-mueller
added a commit
to GridTools/gt4py
that referenced
this pull request
Mar 24, 2025
This [issue](spcl/dace#1959) leaded to some problem, especially in ICON4Py stencil `39_to_40`. However, through an [update](#1915) in GT4Py this leads to now to other problems (`ConstantPropagation` involving AcccessNodes) in `19_to_20`. The underlying issue in DaCe was solved in [PR#1980](spcl/dace#1980) and this PR now deactivate the workaround. It also updates the version of DaCe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue#1959, the issue was about that the inlining transformation destroys the SSA invariant we maintain inside GT4Py.
This invariant states that in every code path there is exactly one AccessNode with that is used to write to a data container.
The PR solves this issue by modifying how the nested SDFG is isolated, before this was done in two steps and is now performed in a single step.
The main idea is that the number of writes is preserved.