Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reload the page after query title changed #6347

Open
wants to merge 3 commits into
base: production
Choose a base branch
from
Open

Reload the page after query title changed #6347

wants to merge 3 commits into from
+1 −2

Conversation

CarolineDenis
Copy link
Contributor

Fixes #2234

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

  • Use the ✏️ icon to change the name of a query
  • Save
  • Verify the page reload and you can see the new name

@CarolineDenis CarolineDenis added this to the 7.10.3 milestone Mar 20, 2025
@CarolineDenis CarolineDenis requested review from acwhite211, sharadsw and a team March 20, 2025 15:45
@CarolineDenis CarolineDenis changed the title Reload the page after query title change Reload the page after query title changed Mar 20, 2025
grantfitzsimmons
grantfitzsimmons approved these changes Mar 28, 2025
View reviewed changes
Copy link
Member

@grantfitzsimmons grantfitzsimmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify the page reload and you can see the new name
Screen.Recording.2025-03-27.at.9.13.52.PM.mov

@grantfitzsimmons grantfitzsimmons requested a review from a team March 28, 2025 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acwhite211 acwhite211 acwhite211 approved these changes

@sharadsw sharadsw sharadsw approved these changes

@grantfitzsimmons grantfitzsimmons grantfitzsimmons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
General Tester Board
Status: 📋Back Log
Milestone
7.10.3
Development

Successfully merging this pull request may close these issues.

The name of a query is not updated after it is changed until a reload
4 participants
@CarolineDenis @acwhite211 @sharadsw @grantfitzsimmons