Add OpenFunc() function
#7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the `OpenFunc()` function that allows us to handle how the DB connection will be opened. You can pass any function that has the same signature as `sql.Open()` and it'll use it to start the connection. The idea is to open the connections with DataDog [SQL wrapper][1] to start collecting APM metrics for our queries. [1]: https://godoc.org/gopkg.in/DataDog/dd-trace-go.v1/contrib/database/sql
ilyalavrenov
approved these changes
Jan 24, 2019
jerius
approved these changes
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
OpenFunc()function that allows us to handle howthe DB connection will be opened. You can pass any function that has the
same signature as
sql.Open()and it'll use it to start the connection.The idea is to open the connections with DataDog SQL wrapper to
start collecting APM metrics for our queries.