Allow for a custom MetricsCollector class to be loaded at runtime #3146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nipper
force-pushed
the
change-config-to-allow-for-custom-metrics
branch
from
1701b20 to
10bff37
Compare
dlstadther
approved these changes
Mar 12, 2022
|
Thanks! No worries! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds in the ability to load a custom subclass of
MetricsCollectorat startup. This is so that if you want to have a private implementation of MetricsCollector you can.It does this by adding the value of
-1to MetricsCollectors which representsCustomand an optionalmetrics_custom_importthat is an optional string in the form ofmodule.sub_module.ClassName. When both are provided it imports the class and returns an instance of it.Motivation and Context
I need to have a private custom metrics collector that I'd like to use and this provides a backwards compatible way to do it.
Have you tested this? If so, how?
I've included a new unit test:
test_custom_metrics_collectorintest/scheduler_test.pySince checks are blocked w/o maintainer approval I ran them here: https://github.com/nipper/luigi/pull/1/checks