Introduce executor configuration to connection factories for Executor to be used with ClusterCommandExecutor
#2594
Comments
jxblum
added a commit
to jxblum/spring-data-redis
that referenced
this issue
Aug 9, 2023
This change allows users to leverage the VirtualThread facilities and AsyncTaskExecutor implementations provided in and by the core Spring Framework as part of our Loom support theme. Closes spring-projects#2594
jxblum
added a commit
to jxblum/spring-data-redis
that referenced
this issue
Aug 10, 2023
…CommandExceutor. Closes spring-projects#2594
mp911de
added a commit
that referenced
this issue
Aug 17, 2023
Move executor from ClusterConfiguration to connection factories as the executor is a Spring concept that isn't tied to endpoint details or the client config. Reorder static factory methods after constructors and property accessors after static factory methods. Inline single-line single-use methods that aren't intended as extension hooks for easier readability. Remove NonNull annotations as default non-nullability is defined on the package level. Simplify tests to use integration tests to avoid excessive mocking. See #2594 Original pull request: #2669
mp911de
added a commit
that referenced
this issue
Aug 17, 2023
Move executor from ClusterConfiguration to connection factories as the executor is a Spring concept that isn't tied to endpoint details or the client config. Reorder static factory methods after constructors and property accessors after static factory methods. Inline single-line single-use methods that aren't intended as extension hooks for easier readability. Remove NonNull annotations as default non-nullability is defined on the package level. Simplify tests to use integration tests to avoid excessive mocking. See #2594 Original pull request: #2669
mp911de
added a commit
that referenced
this issue
Aug 17, 2023
Move executor from ClusterConfiguration to connection factories as the executor is a Spring concept that isn't tied to endpoint details or the client config. Reorder static factory methods after constructors and property accessors after static factory methods. Inline single-line single-use methods that aren't intended as extension hooks for easier readability. Disable TaskExecutor disposal on ClusterCommandExecutor.destroy(). Remove NonNull annotations as default non-nullability is defined on the package level. Simplify tests to use integration tests to avoid excessive mocking. See #2594 Original pull request: #2669
mp911de
added a commit
that referenced
this issue
Aug 17, 2023
Move executor from ClusterConfiguration to connection factories as the executor is a Spring concept that isn't tied to endpoint details or the client config. Reorder static factory methods after constructors and property accessors after static factory methods. Inline single-line single-use methods that aren't intended as extension hooks for easier readability. Disable TaskExecutor disposal on ClusterCommandExecutor.destroy(). Remove NonNull annotations as default non-nullability is defined on the package level. Simplify tests to use integration tests to avoid excessive mocking. See #2594 Original pull request: #2669
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We default to
SimpleAsyncTaskExecutorwhen creating aClusterCommandExecutorwithout the possibility for users to be able to configure the executor. For applications to be able to use Virtual Threads, we should provide a way to configure the executor.The text was updated successfully, but these errors were encountered: