Skip to content

Reinstate RedisCacheConfiguration.getTtl() as deprecated #2628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jxblum opened this issue Jul 6, 2023 · 0 comments
Closed

Reinstate RedisCacheConfiguration.getTtl() as deprecated #2628

jxblum opened this issue Jul 6, 2023 · 0 comments
Assignees
@jxblum
Labels
in: cache RedisCache and CacheManager type: task A general task
Milestone
3.2 M1 (2023.1.0)

Comments

@jxblum
Copy link
Contributor

jxblum commented Jul 6, 2023 •
edited
Loading

As of Spring Data Redis 3.2, it is now possible to dynamically compute the TTL of a cache entry (key/value) on expiration.

As such, the static getTtl():Duration method was removed without properly deprecating the method.

This task reinstates the method as deprecated, referring users to use the new getTtlFunction() method instead.

Issue: #2300
Pull Request: #2597

Original Issue: #1433
Original Pull Request: #2587
@jxblum jxblum self-assigned this Jul 6, 2023
@jxblum jxblum added type: task A general task in: cache RedisCache and CacheManager labels Jul 6, 2023
@jxblum jxblum added this to the 3.2 M1 (2023.1.0) milestone Jul 6, 2023
jxblum added a commit to jxblum/spring-data-redis that referenced this issue Jul 6, 2023
@jxblum
Prepare issue branch for spring-projects#2628.
605fc0f
jxblum added a commit to jxblum/spring-data-redis that referenced this issue Jul 6, 2023
@jxblum
Reinstate RedisCacheConfiguration.getTtl() as deprecated.
053f0de 
Closes spring-projects#2628

Original Pull Request: spring-projects#2597
@jxblum jxblum mentioned this issue Jul 6, 2023
Closed
@jxblum jxblum changed the title Reinstate RedisCacheConfiguration.getTtl() method as deprecated Reinstate RedisCacheConfiguration.getTtl() as deprecated Jul 6, 2023
@mp911de mp911de linked a pull request Jul 14, 2023 that will close this issue
Reinstate RedisCacheConfiguration.getTtl() #2629
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jxblum jxblum

Labels
in: cache RedisCache and CacheManager type: task A general task
Projects
None yet
Milestone
3.2 M1 (2023.1.0)
Development

Successfully merging a pull request may close this issue.

Reinstate RedisCacheConfiguration.getTtl() spring-projects/spring-data-redis
1 participant
@jxblum