Skip to content

BITFIELD INCRBY applies incorrect offset using Lettuce #2903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
osadchuk-roman opened this issue May 10, 2024 · 0 comments
Closed

BITFIELD INCRBY applies incorrect offset using Lettuce #2903

osadchuk-roman opened this issue May 10, 2024 · 0 comments
Assignees
@mp911de
Labels
in: lettuce Lettuce driver type: bug A general bug
Milestone
3.1.12 (2023.0.12)

Comments

@osadchuk-roman
Copy link
Contributor

osadchuk-roman commented May 10, 2024 •
edited
Loading

Offset for bitfield INCRBY subcommand is always used as zero based even when it is defined in multiplied by type length format (e.g. #1)
image

Created pull request with fix: #2901.
Added integration test that help to reproduce this issue and verify it is fixed now.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 10, 2024
@osadchuk-roman osadchuk-roman changed the title BITFIELD INCRBY does not work properly with multiplied by field type length offset BITFIELD INCRBY does not work properly with multiplied by field type length offset with lettuce May 13, 2024
@mp911de mp911de self-assigned this May 13, 2024
@mp911de mp911de linked a pull request May 13, 2024 that will close this issue
Use correct bitfield offset for INCRBY using Lettuce #2901
Closed
4 tasks
@mp911de mp911de changed the title BITFIELD INCRBY does not work properly with multiplied by field type length offset with lettuce BITFIELD INCRBY apply correct offset using Lettuce May 13, 2024
@mp911de mp911de added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels May 13, 2024
@mp911de mp911de changed the title BITFIELD INCRBY apply correct offset using Lettuce BITFIELD INCRBY applies incorrect offset using Lettuce May 13, 2024
@mp911de mp911de added the in: lettuce Lettuce driver label May 13, 2024
mp911de pushed a commit that referenced this issue May 13, 2024
@osadchuk-roman @mp911de
Use correct bitfield offset for INCRBY using Lettuce.
a77df79 
Closes #2903
Original pull request: #2901
mp911de pushed a commit that referenced this issue May 13, 2024
@osadchuk-roman @mp911de
Use correct bitfield offset for INCRBY using Lettuce.
9c3f4f5 
Closes #2903
Original pull request: #2901
@mp911de mp911de added this to the 3.1.12 (2023.0.12) milestone May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mp911de mp911de

Labels
in: lettuce Lettuce driver type: bug A general bug
Projects
None yet
Milestone
3.1.12 (2023.0.12)
Development

Successfully merging a pull request may close this issue.

Use correct bitfield offset for INCRBY using Lettuce osadchuk-roman/spring-data-redis
3 participants
@mp911de @spring-projects-issues @osadchuk-roman