Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish DataBinder. #34307

Closed
wants to merge 2 commits into from
Closed

Polish DataBinder. #34307

wants to merge 2 commits into from

Conversation

remeio
Copy link
Contributor

@remeio remeio commented Jan 22, 2025

Use IllegalArgumentException instead of NumberFormatException.

gh-34305.

@remeio
Polish DataBinder.
1d83df9 
Use IllegalArgumentException instead of NumberFormatException.

spring-projectsgh-34305.

Signed-off-by: Mengqi Xu <2663479778@qq.com>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 22, 2025
@rstoyanchev rstoyanchev self-assigned this Jan 27, 2025
rstoyanchev
rstoyanchev reviewed Jan 27, 2025
View reviewed changes
Copy link
Contributor

@rstoyanchev rstoyanchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion, but NumberFormatException is a subclass of IllegalArgumentException, so it is even more specific. It is also consistent with the exception raised by setter binding.

@rstoyanchev rstoyanchev added status: invalid An issue that we don't feel is valid and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rstoyanchev rstoyanchev rstoyanchev left review comments

Assignees

@rstoyanchev rstoyanchev

Labels
status: invalid An issue that we don't feel is valid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@remeio @rstoyanchev @spring-projects-issues