Implemented property resolving in HATEOAS links. #1328
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lyca Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@lyca Thank you for signing the Contributor License Agreement! |
odrotbohm
pushed a commit
that referenced
this pull request
Jul 27, 2020
We now pipe the detected mapping through the PropertyResolver exposed by the ApplicationContext's Environment. Original pull request: #1328.
odrotbohm
added a commit
that referenced
this pull request
Jul 27, 2020
Made implementation class package protected to not expose it. Avoid the use of Optional for hot code paths. Removed factory method as we only use the type internally anyway. Removed test customizations as the discoverer is now just leniently opting out if not ApplicationContext can be found. Original pull request: #1328.
|
That's polished and merged. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#361 Added the resolving of properties by using org.springframework.web.context.ContextLoader.getCurrentWebApplicationContext().getEnvironment() for obtaining an Environment statically. This works here because the code runs in the context of a web application.
The only breaking change I see is, that testing is only possible if the ContextLoader is initialized otherwise there will be a NPE.
I am unsure, if this use case needs additional effort.