Skip to content

JDBC WebAuthn Repositories #16224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rwinch opened this issue Dec 5, 2024 · 3 comments · Fixed by #16282
Closed

JDBC WebAuthn Repositories #16224

rwinch opened this issue Dec 5, 2024 · 3 comments · Fixed by #16282
Assignees
@rwinch @franticticktick
Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement

Comments

@rwinch
Copy link
Member

rwinch commented Dec 5, 2024

Spring Security currently only has in memory implementations of webauthn repositories. We should add the option to use JDBC
@rwinch rwinch added the type: enhancement A general enhancement label Dec 5, 2024
@rwinch rwinch added this to the 6.5.x milestone Dec 5, 2024
@rwinch rwinch self-assigned this Dec 5, 2024
@franticticktick
Copy link
Contributor

Hi @rwinch , can I take this to work?

@rwinch
Copy link
Member Author

rwinch commented Dec 11, 2024

@franticticktick Thanks for the offer! Yes please send a PR

@rwinch rwinch added the in: web An issue in web modules (web, webmvc) label Dec 11, 2024
franticticktick added a commit to franticticktick/spring-security that referenced this issue Dec 13, 2024
@franticticktick
Add Support JdbcUserCredentialRepository
cc7398d 
Closes spring-projectsgh-16224
franticticktick added a commit to franticticktick/spring-security that referenced this issue Dec 13, 2024
@franticticktick
Add Support JdbcUserCredentialRepository
94fd435 
Closes spring-projectsgh-16224
franticticktick added a commit to franticticktick/spring-security that referenced this issue Dec 13, 2024
@franticticktick
Add Support JdbcUserCredentialRepository
3c87692 
Closes spring-projectsgh-16224
franticticktick added a commit to franticticktick/spring-security that referenced this issue Dec 13, 2024
@franticticktick
Add Support JdbcPublicKeyCredentialUserEntityRepository
139a8a0 
Closes spring-projectsgh-16224
@franticticktick franticticktick mentioned this issue Dec 13, 2024
Merged
@franticticktick
Copy link
Contributor

franticticktick commented Dec 13, 2024 •
edited
Loading

@rwinch i sent PR, could you review it?

franticticktick added a commit to franticticktick/spring-security that referenced this issue Dec 13, 2024
@franticticktick
Add Support JdbcPublicKeyCredentialUserEntityRepository
21da51d 
Closes spring-projectsgh-16224
franticticktick added a commit to franticticktick/spring-security that referenced this issue Dec 13, 2024
@franticticktick
Add Support JdbcUserCredentialRepository
eca12c6 
Closes spring-projectsgh-16224
franticticktick added a commit to franticticktick/spring-security that referenced this issue Dec 13, 2024
@franticticktick
Add Support JdbcPublicKeyCredentialUserEntityRepository
aa64c44 
Closes spring-projectsgh-16224
@rwinch rwinch closed this as completed in 7b07ef5 Dec 20, 2024
rwinch pushed a commit that referenced this issue Dec 20, 2024
@franticticktick @rwinch
Add Support JdbcPublicKeyCredentialUserEntityRepository
fd267df 
Closes gh-16224
@Kehrlann Kehrlann mentioned this issue Jan 14, 2025
Closed
@rwinch rwinch modified the milestones: 6.5.x, 6.5.0-M1, 5.2.0.M1 Jan 18, 2025
kwondh5217 pushed a commit to kwondh5217/spring-security that referenced this issue Feb 4, 2025
@franticticktick @kwondh5217
Add Support JdbcUserCredentialRepository
32c416d 
Closes spring-projectsgh-16224

Signed-off-by: Daeho Kwon <trewq231@naver.com>
kwondh5217 pushed a commit to kwondh5217/spring-security that referenced this issue Feb 4, 2025
@franticticktick @kwondh5217
Add Support JdbcPublicKeyCredentialUserEntityRepository
fb17c5f 
Closes spring-projectsgh-16224

Signed-off-by: Daeho Kwon <trewq231@naver.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwinch rwinch

@franticticktick franticticktick

Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Support JDBC Repositories For WebAuthn franticticktick/spring-security
2 participants
@rwinch @franticticktick