Skip to content

Remove Deprecated Usages of RemoteJWKSet #16251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jzheaux opened this issue Dec 9, 2024 · 6 comments · Fixed by #16537
Closed

Remove Deprecated Usages of RemoteJWKSet #16251

jzheaux opened this issue Dec 9, 2024 · 6 comments · Fixed by #16537
Assignees
@jzheaux @kwondh5217
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue type: enhancement A general enhancement

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Dec 9, 2024 •
edited
Loading

Nimbus has deprecated RemoteJWKSet in favor of using JWKSourceBuilder

By association, JWKSetCache is also deprecated. Since Spring Security has a custom implementation of JWKSetCache, refactoring to wrap a UrlBasedJWKSetSource may be more appropriate than using JWKSourceBuilder.
@jzheaux jzheaux added type: enhancement A general enhancement status: ideal-for-contribution An issue that we actively are looking for someone to help us with in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) labels Dec 9, 2024
@kwondh5217
Copy link
Contributor

Hi, @jzheaux

I’d like to work on this issue as my first contribution to Spring Security. Would it be alright if I take this on?

Thank you!

@franticticktick
Copy link
Contributor

Duplicate.

@kwondh5217
Copy link
Contributor

Hi @franticticktick

I noticed that this issue is marked as a duplicate of #15866. I’d like to clarify: should I continue working on this issue, or would it be better to focus on the original issue (#15866)?

If this issue is still valid, I’d be happy to contribute and help resolve it. Please let me know how I can proceed.

Thank you!

@franticticktick
Copy link
Contributor

Hi @kwondh5217, i marked this as a duplicate so that contributors will pay attention to 15866, as there may be nuances that are worth considering. Nothing more :)

@kwondh5217
Copy link
Contributor

Hi @franticticktick,
Thank you for explaining! I’ll give it a try.
Thanks again!

@rwinch rwinch mentioned this issue Dec 11, 2024
Closed
@jzheaux jzheaux removed the status: ideal-for-contribution An issue that we actively are looking for someone to help us with label Dec 16, 2024
@kwondh5217 kwondh5217 mentioned this issue Dec 16, 2024
Closed
kwondh5217 added a commit to kwondh5217/spring-security that referenced this issue Dec 17, 2024
@kwondh5217
Remove Deprecated Usages of RemoteJWKSet
700bc4e 
close spring-projectsgh-16251
kwondh5217 added a commit to kwondh5217/spring-security that referenced this issue Dec 17, 2024
@kwondh5217
Remove Deprecated Usages of RemoteJWKSet
1be13b4 
close spring-projectsgh-16251
@kwondh5217 kwondh5217 mentioned this issue Dec 17, 2024
Closed
kwondh5217 added a commit to kwondh5217/spring-security that referenced this issue Dec 18, 2024
@kwondh5217
Remove Deprecated Usages of RemoteJWKSet
602d28d 
close spring-projectsgh-16251
kwondh5217 added a commit to kwondh5217/spring-security that referenced this issue Dec 18, 2024
@kwondh5217
Remove Deprecated Usages of RemoteJWKSet
8ca07ef 
close spring-projectsgh-16251
kwondh5217 added a commit to kwondh5217/spring-security that referenced this issue Dec 18, 2024
@kwondh5217
Remove Deprecated Usages of RemoteJWKSet
fa288c2 
close spring-projectsgh-16251
kwondh5217 added a commit to kwondh5217/spring-security that referenced this issue Dec 18, 2024
@kwondh5217
Remove Deprecated Usages of RemoteJWKSet
a3a8f23 
close spring-projectsgh-16251
kwondh5217 added a commit to kwondh5217/spring-security that referenced this issue Dec 20, 2024
@kwondh5217
Merge branch 'spring-projects:main' into spring-projectsgh-16251
7146c46
kwondh5217 added a commit to kwondh5217/spring-security that referenced this issue Jan 29, 2025
@kwondh5217
Merge branch 'spring-projects:main' into spring-projectsgh-16251
782f0dd
kwondh5217 added a commit to kwondh5217/spring-security that referenced this issue Feb 4, 2025
@kwondh5217
Remove Deprecated Usages of RemoteJWKSet
6a4c083 
Closes spring-projectsgh-16251

Signed-off-by: Daeho Kwon <trewq231@naver.com>
kwondh5217 added a commit to kwondh5217/spring-security that referenced this issue Feb 4, 2025
@kwondh5217
Remove Deprecated Usages of RemoteJWKSet
bab5f35 
close spring-projectsgh-16251

Signed-off-by: Daeho Kwon <trewq231@naver.com>
kwondh5217 added a commit to kwondh5217/spring-security that referenced this issue Feb 4, 2025
@kwondh5217
Remove Deprecated Usages of RemoteJWKSet
662f7dd 
close spring-projectsgh-16251

Signed-off-by: Daeho Kwon <trewq231@naver.com>
kwondh5217 added a commit to kwondh5217/spring-security that referenced this issue Feb 4, 2025
@kwondh5217
Remove Deprecated Usages of RemoteJWKSet
43a07a7 
close spring-projectsgh-16251

Signed-off-by: Daeho Kwon <trewq231@naver.com>
kwondh5217 added a commit to kwondh5217/spring-security that referenced this issue Feb 4, 2025
@kwondh5217
Remove Deprecated Usages of RemoteJWKSet
bf4ed14 
close spring-projectsgh-16251

Signed-off-by: Daeho Kwon <trewq231@naver.com>
kwondh5217 added a commit to kwondh5217/spring-security that referenced this issue Feb 4, 2025
@kwondh5217
Remove Deprecated Usages of RemoteJWKSet
f5a669e 
Closes spring-projectsgh-16251

Signed-off-by: Daeho Kwon <trewq231@naver.com>
kwondh5217 added a commit to kwondh5217/spring-security that referenced this issue Feb 4, 2025
@kwondh5217
Remove Deprecated Usages of RemoteJWKSet
85e4650 
Closes spring-projectsgh-16251

Signed-off-by: Daeho Kwon <trewq231@naver.com>
@kwondh5217 kwondh5217 mentioned this issue Feb 4, 2025
Merged
jzheaux added a commit to kwondh5217/spring-security that referenced this issue Feb 5, 2025
@jzheaux
Polish Tests
8147805 
Issue spring-projectsgh-16251
jzheaux pushed a commit to kwondh5217/spring-security that referenced this issue Feb 5, 2025
@kwondh5217 @jzheaux
Remove Deprecated Usages of RemoteJWKSet
6d16691 
Closes spring-projectsgh-16251

Signed-off-by: Daeho Kwon <trewq231@naver.com>
jzheaux added a commit to kwondh5217/spring-security that referenced this issue Feb 5, 2025
@jzheaux
Polish Nimbus JWK Source Implementation
67f663f 
Issue spring-projectsgh-16251
jzheaux added a commit to kwondh5217/spring-security that referenced this issue Feb 5, 2025
@jzheaux
Polish Tests
083b74c 
Issue spring-projectsgh-16251
jzheaux pushed a commit to kwondh5217/spring-security that referenced this issue Feb 5, 2025
@kwondh5217 @jzheaux
Remove Deprecated Usages of RemoteJWKSet
dcc88ec 
Closes spring-projectsgh-16251

Signed-off-by: Daeho Kwon <trewq231@naver.com>
jzheaux added a commit to kwondh5217/spring-security that referenced this issue Feb 5, 2025
@jzheaux
Polish Nimbus JWK Source Implementation
dc57d0b 
Issue spring-projectsgh-16251
jzheaux added a commit to kwondh5217/spring-security that referenced this issue Feb 5, 2025
@jzheaux
Polish Nimbus JWK Source Implementation
36ff8e6 
Issue spring-projectsgh-16251
jzheaux added a commit to kwondh5217/spring-security that referenced this issue Feb 5, 2025
@jzheaux
Polish Tests
20b6fee 
Issue spring-projectsgh-16251
jzheaux pushed a commit to kwondh5217/spring-security that referenced this issue Feb 5, 2025
@kwondh5217 @jzheaux
Remove Deprecated Usages of RemoteJWKSet
2349247 
Closes spring-projectsgh-16251

Signed-off-by: Daeho Kwon <trewq231@naver.com>
jzheaux added a commit to kwondh5217/spring-security that referenced this issue Feb 5, 2025
@jzheaux
Polish Nimbus JWK Source Implementation
457f4db 
Issue spring-projectsgh-16251
jzheaux added a commit that referenced this issue Feb 5, 2025
@jzheaux
Polish Tests
f9824fd 
Issue gh-16251
jzheaux pushed a commit that referenced this issue Feb 5, 2025
@kwondh5217 @jzheaux
Remove Deprecated Usages of RemoteJWKSet
7b7abb2 
Closes gh-16251

Signed-off-by: Daeho Kwon <trewq231@naver.com>
jzheaux added a commit that referenced this issue Feb 5, 2025
@jzheaux
Polish Nimbus JWK Source Implementation
11113ad 
Issue gh-16251
@jzheaux
Copy link
Contributor Author

jzheaux commented Feb 18, 2025

Superceded by #16537

@jzheaux jzheaux added the status: duplicate A duplicate of another issue label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

@kwondh5217 kwondh5217

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
3 participants
@jzheaux @franticticktick @kwondh5217