Include AuthenticationRequest in AuthenticationException #16505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
force-pushed
the
gh-16444
branch
2 times, most recently
from
3ecbe0f to
872f77e
Compare
jzheaux
requested changes
Feb 3, 2025
core/src/main/java/org/springframework/security/core/AuthenticationException.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/springframework/security/core/AuthenticationException.java
Outdated
Show resolved
Hide resolved
jzheaux
requested changes
Mar 9, 2025
core/src/main/java/org/springframework/security/core/AuthenticationException.java
Outdated
Show resolved
Hide resolved
jzheaux
added
in: core
jzheaux
changed the title
jzheaux
approved these changes
Mar 20, 2025
Store the authentication request details in the `authRequest` field of `AuthenticationException` when an authentication exception occurs. Closes spring-projectsgh-16444 Signed-off-by: amm0124 <amm0124@naver.com>
- Add getter for reading the request - Update BadCredentialsMixing to ignore authentication - Allow exception to be mutable Issue spring-projectsgh-16444
- Isolated exception construction - Isolated entry point subscription Issue spring-projectsgh-16444
|
Thanks for the PR, @amm0124! In addition to your contribution, I updated the Spring Security's authentication components to use the setter when throwing exceptions in 659e7d2. I also did a slight polish of your original contribution in order to facilitate that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
authRequestfield ofAuthenticationExceptionwhen an authentication exception occurs.@rwinch