Skip to content

Update DeferredCsrfToken to implement Supplier #16905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kwondh5217
Copy link
Contributor

Closes gh-16870

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 8, 2025
@jzheaux
Copy link
Contributor

jzheaux commented Apr 8, 2025

Hi, @kwondh5217! Thanks for the PR. Will you please update the commit to include Closes gh-16870? This helps when folks are researching the codebase to learn why a change was made. Something like this:

DeferredCsrfToken Implements Supplier

Closes gh-16870

@jzheaux jzheaux self-assigned this Apr 8, 2025
@jzheaux jzheaux removed the status: waiting-for-triage An issue we've not yet triaged label Apr 8, 2025
@jzheaux
Copy link
Contributor

jzheaux commented Apr 8, 2025

Also, @kwondh5217, will you please update any 2002-20xx copyright years to be 2002-2025?

@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement labels Apr 8, 2025
Closes spring-projectsgh-16870

Signed-off-by: Daeho Kwon <trewq231@naver.com>
@kwondh5217
Copy link
Contributor Author

Hi @jzheaux, I’ve updated the commit message to include Closes gh-16870 and fixed the copyright years to 2002-2025.

Let me know if there's anything else to improve. Thanks for the review!

@jzheaux jzheaux added this to the 6.5.0-RC1 milestone Apr 8, 2025
@jzheaux jzheaux enabled auto-merge (rebase) April 9, 2025 20:17
@jzheaux
Copy link
Contributor

jzheaux commented Apr 9, 2025

Thanks for the PR, @kwondh5217! This has been merged into main as 9908d96 and will go out in the next release.

It was a different commit because for an unknown reason, the CI build didn't kick off to confirm the build passed, so I needed to verify that locally.

In the future, if you submit a PR using a branch instead of using main, I can push these updates to your branch and then merge in GitHub. This will make the PR say "Merged" instead of "Closed".

@jzheaux jzheaux closed this Apr 9, 2025
auto-merge was automatically disabled April 9, 2025 20:28

Pull request was closed

@kwondh5217
Copy link
Contributor Author

@jzheaux Thanks! Really appreciate your help and the tip!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update DeferredCsrfToken to implement Supplier
3 participants