Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed to be able to get xx_wait_time from environment variable #77

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Fixed to be able to get xx_wait_time from environment variable #77

merged 1 commit into from
Mar 7, 2023

Conversation

niqniqniqq
Copy link
Contributor

Description

The following constants can now be set as environment variables

  • maxJobCreationWaitTimeInSeconds
  • maxJobRunWaitTimeInSeconds

Checklist

Please check if applicable

  • Tests have been added (if applicable, ie. when operator codes are added or modified)
  • Relevant docs have been added or modified (if applicable, ie. when new features are added or current features are modified)

Relevant issue #

#76

@niqniqniqq niqniqniqq requested a review from a team March 2, 2023 11:07
@banatt banatt requested a review from a team March 2, 2023 12:31
@niqniqniqq niqniqniqq requested review from akitok, ksudate, S-mishina and banatt and removed request for a team March 3, 2023 01:48
ksudate
ksudate approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@ksudate ksudate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@niqniqniqq
Copy link
Contributor Author

@ksudate @banatt
Thanks for the review.

@niqniqniqq niqniqniqq merged commit 55efbad into st-tech:main Mar 7, 2023
@niqniqniqq niqniqniqq deleted the add_max_job_creation_time_option branch March 7, 2023 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksudate ksudate ksudate approved these changes

@banatt banatt banatt approved these changes

@akitok akitok Awaiting requested review from akitok

@S-mishina S-mishina Awaiting requested review from S-mishina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niqniqniqq @ksudate @banatt