Skip to content

stg rebase <ref> does not work when ref contains @ #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lthms opened this issue Mar 30, 2023 · 2 comments · Fixed by #307
Closed

stg rebase <ref> does not work when ref contains @ #306

lthms opened this issue Mar 30, 2023 · 2 comments · Fixed by #307

Comments

@lthms
Copy link
Contributor

lthms commented Mar 30, 2023

Hi everyone.

I updated to the lastest version today, and found a regression related to reference handling. As far as I can tell, git revisions are not recognized when they contain certain character. At $WORK we use @ in our branch names, for instance.

How to reproduce

git init
touch t
git add t
git commit -m "add t"
git branch lthms@reproduce
stg init
stg rebase lthms@reproduce

was working with 2.1.0, but does not work with 2.2.1.

@lthms
Copy link
Contributor Author

lthms commented Mar 31, 2023

As far as I can tell, the culprit is likely to be gix_revision::spec::parse. I’ll keep investigating.

@lthms
Copy link
Contributor Author

lthms commented Apr 1, 2023

Good news, I was able to check that GitoxideLabs/gitoxide#803 fixes the issue locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant