Skip to content

feat: add array/base/count-same-value #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Feb 22, 2024
Merged

feat: add array/base/count-same-value #1339

merged 13 commits into from
Feb 22, 2024
+812 −0

Conversation

skoriop
Copy link
Contributor

@skoriop skoriop commented Feb 21, 2024

Resolves #1325 .

Description

What is the purpose of this pull request?

This pull request adds count-same-value to array/base.

Related Issues

Does this pull request have any related issues?

This pull request resolves #1325 .

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

stdlib-bot
stdlib-bot reviewed Feb 21, 2024
View reviewed changes
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Feb 21, 2024
@kgryte
Apply suggestions from code review
2fe96a5 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
9062cce 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
2570bd2 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
b93bb76 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte requested changes Feb 21, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skoriop Thanks for working on this. Overall, this is looking pretty good. I left a suggestion for improving the complex array case and added suggestions for improving the test cases. Once resolved, this should be ready for merge.

@kgryte kgryte changed the title feat: add count-same-value to array/base feat: add array/base/count-same-value Feb 21, 2024
@skoriop skoriop requested a review from kgryte February 22, 2024 13:26
@kgryte
Apply suggestions from code review
e99407e 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
72070f1 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
f49b7a7 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
19de0e5 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
0f3f5d0 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
30b3021 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @skoriop!

@kgryte
Copy link
Member

kgryte commented Feb 22, 2024

I'll merge this once CI finishes.

@kgryte kgryte merged commit 634044b into stdlib-js:develop Feb 22, 2024
kgryte added a commit that referenced this pull request Mar 16, 2024
@kgryte
docs: clean-up examples and descriptions
215a6ec 
Ref: #1339
kgryte added a commit that referenced this pull request Mar 16, 2024
@kgryte
test: add test case to ensure full test coverage
9d7da34 
Ref: #1339
Ref: 634044b
kgryte added a commit that referenced this pull request Mar 16, 2024
@kgryte
docs: add notes concerning algorithm
e925974 
Ref: #1339
Ref: 634044b
kgryte added a commit that referenced this pull request Mar 16, 2024
@kgryte
docs: add same value example
e3eff9b 
Ref: #1339
Ref: 634044b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stdlib-bot stdlib-bot stdlib-bot left review comments

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add @stdlib/array/base/count-same-value
3 participants
@skoriop @kgryte @stdlib-bot