Skip to content

feat: add boolean dtype support to ndarray/empty* and ndarray/base/empty* packages #2588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jul 13, 2024

Conversation

Jaysukh-409
Copy link
Member

Resolves: Subtask of #2547

Description

What is the purpose of this pull request?

This pull request:

  • This PR updates the test file of the below mentioned packages:
  • @stdlib/ndarray/base/zeros
  • @stdlib/ndarray/base/zeros-like
  • @stdlib/ndarray/base/empty
  • @stdlib/ndarray/base/empty-like
  • @stdlib/ndarray/zeros
  • @stdlib/ndarray/zeros-like
  • @stdlib/ndarray/empty
  • @stdlib/ndarray/empty-like

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@Jaysukh-409 Jaysukh-409 added the Tests Pull requests specifically adding tests. label Jul 13, 2024
@kgryte
Copy link
Member

kgryte commented Jul 13, 2024

@Jaysukh-409 I don't think we need to support bool dtypes in zeros and zeros-like. We should, however, update the documentation in those packages to convey that only numeric dtypes are intended for the zero* packages.

@kgryte
Copy link
Member

kgryte commented Jul 13, 2024

It is also not clear why the TypeScript declarations or the benchmarks were not updated for the empty* packages.

@kgryte kgryte changed the title test: add boolean dtype test for ndarray/* and ndarray/base/* feat: add boolean dtype support to ndarray/empty* and ndarray/base/empty* packages Jul 13, 2024
@kgryte kgryte added Enhancement Issue or pull request for enhancing existing functionality. and removed Tests Pull requests specifically adding tests. labels Jul 13, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Adding support needed more work beyond just updating tests.

@kgryte kgryte merged commit 71cf5a0 into stdlib-js:develop Jul 13, 2024
8 checks passed
@kgryte kgryte deleted the test/ndarray branch July 13, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Issue or pull request for enhancing existing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants