-
-
Notifications
You must be signed in to change notification settings - Fork 806
feat: add boolean dtype support to ndarray/empty*
and ndarray/base/empty*
packages
#2588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Jaysukh-409 I don't think we need to support |
It is also not clear why the TypeScript declarations or the benchmarks were not updated for the |
ndarray/*
and ndarray/base/*
ndarray/empty*
and ndarray/base/empty*
packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Adding support needed more work beyond just updating tests.
Resolves: Subtask of #2547
Description
This pull request:
@stdlib/ndarray/base/zeros
@stdlib/ndarray/base/zeros-like
@stdlib/ndarray/base/empty
@stdlib/ndarray/base/empty-like
@stdlib/ndarray/zeros
@stdlib/ndarray/zeros-like
@stdlib/ndarray/empty
@stdlib/ndarray/empty-like
Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers