Set the userid on the GH bot for pushes in bump-version #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Set the userid on the GH bot for pushes in the bump-version action and remove modifications to global git config.
Why
The userid is the recommended way to reference the GH bot now:
user.emailto be41898282+github-actions[bot]@users.noreply.git.1-hub.cnactions/checkout#1707The accompanying changes to remove the
--globalmakes our use consistent with the PR above's recommendations.We started to see failing builds that do a git push as the GH bot, e.g.:
Nothing changes on our side that I'm aware of, although I have an ask out to ops at the thread below to confirm:
Folks in this community forum got it working again by removing modifications to the global git config:
These changes might not fix the problem, but they're updating our existing use to match recommendations so are good to make regardless.