Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+ fix minor issue: scenehandler compile errors - missing template arguments #792

Merged

Conversation

jaku-jaku
Copy link
Contributor

scenehandler fixed for issue #784

@christian-rauch
Copy link
Collaborator

Can you give the commit a better name? E.g. "fix scenehandler compile errors" or something more expressive that naming the issue ID in the commit title. If you write "Fixes #" in the PR, then this will automatically close the issue once the PR has been merged.

@jaku-jaku jaku-jaku changed the title + fix issue https://github.com/stevenlovegrove/Pangolin/issues/784 + fix minor issue: scenehandler compile errors Sep 26, 2022
@jaku-jaku
Copy link
Contributor Author

Can you give the commit a better name? E.g. "fix scenehandler compile errors" or something more expressive that naming the issue ID in the commit title. If you write "Fixes #" in the PR, then this will automatically close the issue once the PR has been merged.

Sounds good. Done.

@jaku-jaku jaku-jaku changed the title + fix minor issue: scenehandler compile errors + fix minor issue: scenehandler compile errors - missing template Sep 26, 2022
@jaku-jaku jaku-jaku changed the title + fix minor issue: scenehandler compile errors - missing template + fix minor issue: scenehandler compile errors - missing template arguments Sep 26, 2022
@stevenlovegrove stevenlovegrove merged commit 0bc87e2 into stevenlovegrove:master Oct 1, 2022
@stevenlovegrove
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants